Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the missing argument of re.sub #1948

Merged

Conversation

numerology
Copy link

@numerology numerology commented Aug 26, 2019

This should fix the current observed post submit check failure.

@Bobgy Thanks for noting this.


This change is Reviewable

@Bobgy
Copy link
Contributor

Bobgy commented Aug 26, 2019

awesome, thanks!

/lgtm
/approve

@numerology
Copy link
Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy, numerology

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 27d6742 into kubeflow:master Aug 26, 2019
@numerology numerology deleted the sample-test-post-submit-check-fix branch August 26, 2019 16:04
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants