Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate pipeline name in pipeline spec #1842

Merged
merged 7 commits into from
Aug 15, 2019

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Aug 14, 2019

The UI can skip sending additional call to get pipeline name.
/assign @rileyjbauer @ajchili


This change is Reviewable

@ajchili
Copy link
Member

ajchili commented Aug 14, 2019

/lgtm

@IronPan
Copy link
Member Author

IronPan commented Aug 14, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 15, 2019
@IronPan
Copy link
Member Author

IronPan commented Aug 15, 2019

/retest

@ajchili
Copy link
Member

ajchili commented Aug 15, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit f1c9594 into kubeflow:master Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants