Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests - Upgrade Minikube and Kubernetes for new Docker release #183

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Nov 9, 2018

This change is Reviewable

@coveralls
Copy link

coveralls commented Nov 9, 2018

Pull Request Test Coverage Report for Build 171

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.592%

Totals Coverage Status
Change from base Build 162: 0.0%
Covered Lines: 1535
Relevant Lines: 2179

💛 - Coveralls

@Ark-kun Ark-kun changed the title Tests - Upgrade minikube due for new Docker release Tests - Upgrade Minikube and Kubernetes for new Docker release Nov 9, 2018
@IronPan
Copy link
Member

IronPan commented Nov 10, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d68ea51 into master Nov 10, 2018
IronPan added a commit that referenced this pull request Nov 11, 2018
@Ark-kun Ark-kun deleted the avolkov/Tests---Upgrade-minikube-due-for-new-Docker-release branch January 15, 2019 22:10
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
…x. (kubeflow#183)

* Copy artifacts should make the file names unique by appending a suffix.

* See kubeflow/training-operator#748
* A test can run multiple instances of a workflow but with different parameters.
* In this case we need to make sure the junit files and other artifacts
  copied to GCS for gubernator have unique names.

* One way to make this easier is to have copy-artifacts automatically
  append a unique suffix to each file before copying it to GCS.

* Fix lint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants