Container builder default gcr #1806
Conversation
gaoning777
changed the title
|
fixes #1775 |
|
/test kubeflow-pipeline-sample-test |
4 similar comments
|
/test kubeflow-pipeline-sample-test |
|
/test kubeflow-pipeline-sample-test |
|
/test kubeflow-pipeline-sample-test |
|
/test kubeflow-pipeline-sample-test |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaoning777 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| """ | ||
| Args: | ||
| gcs_staging (str): GCS bucket/blob that can store temporary build files, | ||
| default is gs://PROJECT_ID/kfp_container_build_staging. | ||
| gcr_image_tag (str): GCR image tag where the target image is pushed |
There was a problem hiding this comment.
The gcr_image_tag parameter name might be confusing:
- I'm not sure it's GCR-specific
- Docker already uses the term
tagfor a different concept
What do you think about naming it default_image_name?
P.S. Docker calls them "image repo"s
There was a problem hiding this comment.
it currently only support gcr, thus naming it this way.
I'm OK with renaming it once we support other registries.
| else: | ||
| nb_id = self._get_instance_id() | ||
| except: | ||
| raise ValueError('Please provide the gcr_image_tag.') |
There was a problem hiding this comment.
... when running outside of the KFP cluster.
There was a problem hiding this comment.
It currently works for ai platform notebook and kf notebook where the project id is available. Otherwise, users need to provide one.
|
The tests seems to be failing when developing locally: @gaoning777 Can you please look into it? |
|
addressing the comments here: #1892 |
This change is