Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move samples to the correct location #1759

Merged
merged 3 commits into from
Aug 7, 2019
Merged

Move samples to the correct location #1759

merged 3 commits into from
Aug 7, 2019

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Aug 7, 2019

AI-platform: move to the core, restructure the samples
artifact_location: move to the core
volume_op/volume_snapshot_op: keep the basic one that demonstrates the feature while placing the others to the contrib.


This change is Reviewable

@numerology
Copy link

/lgtm

@gaoning777
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaoning777 gaoning777 merged commit 81db6bd into kubeflow:master Aug 7, 2019
@gaoning777 gaoning777 deleted the move-samples branch August 7, 2019 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants