Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor aws samples to match new folder structure #1741

Merged
merged 1 commit into from
Aug 6, 2019

Conversation

carolynwang
Copy link
Contributor

@carolynwang carolynwang commented Aug 5, 2019

Summary
Updated links to samples in READMEs and paths to components in sample pipelines to match new samples folder structure


This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @carolynwang. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Jeffwan
Copy link
Member

Jeffwan commented Aug 6, 2019

/ok-to-test

@Jeffwan
Copy link
Member

Jeffwan commented Aug 6, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jeffwan
Copy link
Member

Jeffwan commented Aug 6, 2019

/test kubeflow-pipeline-sample-test

@k8s-ci-robot k8s-ci-robot merged commit 351f456 into kubeflow:master Aug 6, 2019
@carolynwang carolynwang deleted the sagemaker-components branch August 6, 2019 15:53
@gaoning777
Copy link
Contributor

Thanks for fixing this. We should've updated it when the samples are restructured.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants