Delete KFP component before reinstalling again #1736
Conversation
IronPan
changed the title
|
/retest |
test/deploy-kubeflow.sh
Outdated
| @@ -45,7 +45,7 @@ function clean_up { | |||
| # delete the storage | |||
| gcloud deployment-manager --project=${PROJECT} deployments delete ${KFAPP}-storage --quiet | |||
| } | |||
| trap clean_up EXIT SIGINT SIGTERM | |||
| # trap clean_up EXIT SIGINT SIGTERM | |||
There was a problem hiding this comment.
You should probably re-enable the trap.
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@IronPan: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
If there is any issue in the code to be tested that causing the KFP components image fail to launch (CrashLoopBackOff for example), Kubernetes will by default keep the old pod running. The test will thus test against an official image instead.
Delete KFP will ensure the KFP to be tested either not start at all, or healthy.
This change is