Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename InputPath -> Source for Visualization API definition #1717

Merged
merged 2 commits into from
Aug 5, 2019

Conversation

ajchili
Copy link
Member

@ajchili ajchili commented Aug 1, 2019

  • Changed name of data path/pattern variable from InputPath to Source to improve consistency with current visualization method
  • Updated unit tests to reflect name change
  • Regenerated swagger definitions to reflect name change

This change is Reviewable

* Changed name of data path/pattern variable from InputPath to Source to improve consistency with current visualization method
* Updated unit tests to reflect name change
* Regenerated swagger definitions to reflect name change
@ajchili
Copy link
Member Author

ajchili commented Aug 1, 2019

/assign @IronPan

@IronPan
Copy link
Member

IronPan commented Aug 2, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor

Ark-kun commented Aug 3, 2019

/retest

@ajchili
Copy link
Member Author

ajchili commented Aug 5, 2019

/test kubeflow-pipeline-sample-test

@k8s-ci-robot k8s-ci-robot merged commit fa1abde into kubeflow:master Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants