Moving component_sdk to components/gcp/ #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ark-kun
force-pushed
the
Moved-component_sdk-to-components/gcp
branch
from
50a6999
to
d604c02
Compare
Ark-kun
changed the title
|
I don't have objection and thanks for the change. |
|
/lgtm |
|
/test kubeflow-pipeline-e2e-test |
|
/approve |
1 similar comment
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun, hongye-sun, IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the GCP components' code to
components/gcpto makes the component code more localized and reduce the confusion of people looking at the Pipelines project.components,sdkandcomponent_sdkdirectories which can be confusing.component_sdkis only used by the GCP components located incomponents/gcp/.WDYT @hongye-sun?
This change is