Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clears the workflow's name in GetWorkflowSpec and uses it for the GenerateName #1689

Merged
merged 1 commit into from
Jul 26, 2019

Conversation

rileyjbauer
Copy link
Contributor

@rileyjbauer rileyjbauer commented Jul 26, 2019

This will prevent name collisions when cloning runs generated by jobs.
Related to #1266


This change is Reviewable

@IronPan
Copy link
Member

IronPan commented Jul 26, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f63b57b into kubeflow:master Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants