Separate codegen from containerbuild 2 #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r directories in the containerbuilder
|
/test kubeflow-pipeline-sample-test |
Ark-kun
reviewed
Jul 29, 2019
Ark-kun
reviewed
Jul 29, 2019
Ark-kun
reviewed
Jul 29, 2019
Ark-kun
reviewed
Jul 29, 2019
| tarball.add(value, arcname=key) | ||
|
|
||
| def _prepare_buildfiles(self, local_tarball_path, docker_filename, python_filename=None, requirement_filename=None): | ||
| def _prepare_files(self, local_dir, docker_filename, python_filename=None, requirement_filename=None): |
There was a problem hiding this comment.
This function is only called once and most of the parameters are not used in that call. Maybe we should inline it and save 15 lines.
There was a problem hiding this comment.
I'm declaring the function to make it easier in the future to prepare build files.
Ark-kun
reviewed
Jul 29, 2019
hongye-sun
reviewed
Jul 29, 2019
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaoning777 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
separate the container build from the component build;
add support for directory build in the container builder
This change is