Sets min height/width of all fullscreen viewers to 80% #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yebrahim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yebrahim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Linchin
pushed a commit
to Linchin/pipelines
that referenced
this pull request
Apr 11, 2023
* In kubeflow/kubeflow#1109 We are seeing lots of timeouts waiting for the test workflows too complete. * Bump the timeout to 1 hour.
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
* Add logic for pb to internal model * Add logic for pb to internal model * Note issue with scalars * Add pb conversion for scalars * Fix error log, add options for CLI * Use pointers to construct internal model * Update dims to catch non-batchable inputs * Complete pb2internal except for one edge case * Need to confirm whether there is a default shape when TensorShape is nil in SigDef * Make CLI more user friendly * Return errors instead of log fatal * Make code more readable and fail fast
HumairAK
pushed a commit
to red-hat-data-services/data-science-pipelines
that referenced
this pull request
Mar 11, 2024
…low#167) * update conditional feature with the catalog condition approach * fix lint errors * add catalog condition template * change parameter name * Init README * amend parameter reference * Add documentation and increase clarity of code * improve readability * Update catalog
HumairAK
added a commit
to red-hat-data-services/data-science-pipelines
that referenced
this pull request
Mar 11, 2024
Update http/grpc packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #160
Properly sizing the fullscreen viewer for HTML artifacts is difficult because we use iframes.
This is something of a workaround to ensure all viewers expand sufficiently in fullscreen mode until we can determine a better way to size them automatically.
This change is