SDK - Removed the build_image parameter from build_python_component function #1657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test kubeflow-pipeline-sample-test |
Ark-kun
changed the title
…onent function This parameter has never worked and has no useful purpose.
Ark-kun
force-pushed
the
SDK---Removed-the-broken-build_image-parameter-from-build_python_component-function
branch
from
96da012
to
c67d9d4
Compare
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
…eter-from-build_python_component-function
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
Jeffwan
approved these changes
Aug 13, 2019
Ark-kun
deleted the
SDK---Removed-the-broken-build_image-parameter-from-build_python_component-function
branch
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
* Add SANs to server.crt
On my testing environment (debian 11, openssl 1.1.1k, minikube with k8s 1.20,
go 1.15, kfserving 0.5) I get some TLS errors when testing kfserving,
namely
"x509: certificate relies on legacy Common Name field, use SANs or temporarily enable Common Name matching"
when trying to deploy a simple InferenceService resource.
After some digging I found this problem:
```
openssl req -noout -text -in server.csr | grep "Subject Alternative Name" -A 1
X509v3 Subject Alternative Name:
DNS:kfserving-webhook-server-service, DNS:kfserving-webhook-server-service.kfserving-system, DNS:kfserving-webhook-server-service.kfserving-system.svc, DNS:kfserving-webhook-server-service.kfserving-system.svc.cluster, DNS:kfserving-webhook-server-service.kfserving-system.svc.cluster.local
openssl x509 -in server.crt -text -noout | grep "Subject Alternative Name" -A 1
```
Meanwhile if I add this patch:
```
openssl x509 -in server.crt -text -noout | grep "Subject Alternative Name" -A 1
X509v3 Subject Alternative Name:
DNS:kfserving-webhook-server-service, DNS:kfserving-webhook-server-service.kfserving-system, DNS:kfserving-webhook-server-service.kfserving-system.svc, DNS:kfserving-webhook-server-service.kfserving-system.svc.cluster, DNS:kfserving-webhook-server-service.kfserving-system.svc.cluster.local
```
As far as I got go 1.15 introduces a stricter policy for TLS certs, and
openssl by default doesn't copy SANs from a .csr to .crt if not
explicitly told.
gh: kubeflow#1657
* Add patch for conversion webhook in self-signed-ca.sh
Co-authored-by: haijohn <haijohnzju@gmail.com>
gh: kubeflow#1657
Co-authored-by: haijohn <haijohnzju@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1661
This parameter seems to be unused and it's not clear what's the use case for it.
This change is