Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests - Testing master+branch instead of just branch #165

Merged
merged 5 commits into from
Nov 9, 2018
Merged

Tests - Testing master+branch instead of just branch #165

merged 5 commits into from
Nov 9, 2018

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Nov 9, 2018 •
edited by jlewi
Loading

Fixes #163

This change is Reviewable

@Ark-kun Ark-kun requested a review from IronPan November 9, 2018 02:19
@Ark-kun Ark-kun requested a review from vicaire November 9, 2018 02:33
@k8s-ci-robot k8s-ci-robot added size/M and removed size/S labels Nov 9, 2018
IronPan
IronPan reviewed Nov 9, 2018
View reviewed changes
Copy link
Member

@IronPan IronPan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

test/api-integration-test/run_test.sh Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm label Nov 9, 2018
@IronPan
Copy link
Member

IronPan commented Nov 9, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit b190e72 into master Nov 9, 2018
@Ark-kun Ark-kun deleted the avolkov/Tests---Testing-master+branch-instead-of-just-branch branch November 9, 2018 22:39
@k8s-ci-robot
Copy link
Contributor

@Ark-kun: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
presubmit-e2e-test 82e058d link /test presubmit-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 9, 2018

/test presubmit-e2e-test

@IronPan IronPan mentioned this pull request Nov 11, 2018
Closed
IronPan added a commit that referenced this pull request Nov 11, 2018
@IronPan
Revert "Tests - Testing master+branch instead of just branch (#165)"
2552c7a 
This reverts commit b190e72.
@Ark-kun Ark-kun mentioned this pull request Nov 12, 2018
Closed
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
@jlewi @k8s-ci-robot
Remove helm from cluster setup because we don't use it. (kubeflow#165)
a50fb88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IronPan IronPan IronPan left review comments

@vicaire vicaire vicaire requested changes

@qimingj qimingj Awaiting requested review from qimingj

@gaoning777 gaoning777 Awaiting requested review from gaoning777

Assignees

@IronPan IronPan

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ark-kun @k8s-ci-robot @IronPan @vicaire