Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets min widths for buttons to avoid text wrapping #1637

Merged
merged 2 commits into from
Jul 24, 2019

Conversation

rileyjbauer
Copy link
Contributor

@rileyjbauer rileyjbauer commented Jul 17, 2019

This change is Reviewable

@ajchili
Copy link
Member

ajchili commented Jul 17, 2019

/lgtm

@ajchili
Copy link
Member

ajchili commented Jul 18, 2019

@rileyjbauer the snapshots for the tests need to be updated.

@rileyjbauer
Copy link
Contributor Author

/retest

1 similar comment
@rileyjbauer
Copy link
Contributor Author

/retest

@rileyjbauer
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@ajchili
Copy link
Member

ajchili commented Jul 23, 2019

/lgtm

@rileyjbauer
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rileyjbauer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e059511 into kubeflow:master Jul 24, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Decouple http handler with KFModel

* Add model type enum

* Throw exception for unknown type

* Implement model worker with RayServe deployment API

* Add ray remote custom example

* Update custom model server doc

* Update custom model inference yaml

* Check the model deployment type

* Fix linting

* Add local testing instruction

* Fix image name

* Reduce cpu resource
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants