add GCP marketplace application manifest for kubeflow pipelines #1621
Conversation
|
/assign @eshiroma |
|
@IronPan: GitHub didn't allow me to assign the following users: eshiroma. Note that only kubeflow members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
| description: |- | ||
| Machine Learning Pipeline on Kubernetes | ||
| maintainers: | ||
| - name: Google Click to Deploy |
There was a problem hiding this comment.
Unless the final application will end up in https://github.com/GoogleCloudPlatform/click-to-deploy, can you list Kubeflow-related maintainers info here? (also in the README)
| type: string | ||
| x-google-marketplace: | ||
| type: NAMESPACE | ||
|
|
There was a problem hiding this comment.
Include one property for each container image (besides the deployer itself) that you'll use in your app.
https://github.com/GoogleCloudPlatform/marketplace-k8s-app-tools/blob/master/docs/building-deployer-helm.md#parameterize-the-images
The app might still install with mpdev install, but our system relies on properties with x-google-marketplace type: IMAGE for determining which images your app uses (both for publishing them, and then to properly reference those published images at deploy time).
| images: | ||
| mysql: mysql:5.6 | ||
| minio: minio/minio:RELEASE.2018-02-09T22-40-05Z | ||
| apiServer: gcr.io/ml-pipeline/api-server:0.1.23 |
There was a problem hiding this comment.
Should we templatize the version here and make it the same as the version in application.yaml?
There was a problem hiding this comment.
thanks. I updated the image tag to use $tag which is required by marketplace.
the $tag doesn't seem to be accessible from application.yaml. For now maybe I'll follow other the marketplace samples.
|
/lgtm |
|
@IronPan This PR seems to be pending for a while. |
|
/assign @huyhg |
|
@IronPan: GitHub didn't allow me to assign the following users: huyhg. Note that only kubeflow members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…flow#1621) * move kustomize to subdirectory * add application cr * add label application crd can recognize * Update README.md * Update README.md * Update README.md * add schema * update * stage * add deployer * sync components * add components * fix issues * add configuration * fix * fix * update
By following the GCP Marketplace doc
https://cloud.google.com/marketplace/docs/partners/kubernetes-solutions/
And follow the same structure as other samples
https://github.com/GoogleCloudPlatform/click-to-deploy/tree/master/k8s
Also update the api versions for K8s resources.
This change is