Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acknowledge Argo. #157

Merged
merged 1 commit into from
Nov 9, 2018
Merged

Acknowledge Argo. #157

merged 1 commit into from
Nov 9, 2018

Conversation

jlewi
Copy link
Contributor

@jlewi jlewi commented Nov 9, 2018 •
edited
Loading

This change is Reviewable

@jlewi
Copy link
Contributor Author

jlewi commented Nov 9, 2018

/assign @vicaire

@qimingj
Copy link
Contributor

qimingj commented Nov 9, 2018

/lgtm
/approve

@paveldournov
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@jlewi: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
presubmit-unit-test 76a4d1a link /test presubmit-unit-test
build-image 76a4d1a link /test build-image

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vicaire
Copy link
Contributor

vicaire commented Nov 9, 2018

/lgtm

@vicaire
Copy link
Contributor

vicaire commented Nov 9, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qimingj, vicaire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qimingj, vicaire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vicaire vicaire merged commit 8b4e280 into kubeflow:master Nov 9, 2018
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
@k8s-ci-robot
Updates for d.k.o; based on ks 0.11.0; params added (kubeflow#157)
8fd35e0
HumairAK referenced this pull request in red-hat-data-services/data-science-pipelines Mar 11, 2024
@drewbutlerbb4
Add troubleshooting pointer for venv errors (#157)
9eec3ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicaire vicaire vicaire approved these changes

@qimingj qimingj qimingj approved these changes

@IronPan IronPan Awaiting requested review from IronPan

Assignees

@paveldournov paveldournov

@qimingj qimingj

@vicaire vicaire

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jlewi @qimingj @paveldournov @k8s-ci-robot @vicaire