Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Visualization API endpoint #1565

Merged
merged 8 commits into from
Jul 10, 2019

Conversation

ajchili
Copy link
Member

@ajchili ajchili commented Jun 26, 2019

This change is Reviewable

backend/api/visualization.proto Outdated Show resolved Hide resolved
backend/api/visualization.proto Outdated Show resolved Hide resolved
backend/api/visualization.proto Outdated Show resolved Hide resolved
backend/api/visualization.proto Outdated Show resolved Hide resolved
backend/api/visualization.proto Outdated Show resolved Hide resolved
backend/api/visualization.proto Outdated Show resolved Hide resolved
backend/api/visualization.proto Show resolved Hide resolved
backend/api/visualization.proto Outdated Show resolved Hide resolved
backend/api/visualization.proto Outdated Show resolved Hide resolved
backend/api/visualization.proto Outdated Show resolved Hide resolved
@ajchili ajchili changed the title [WIP] Add Visualization API endpoints Add Visualization API endpoints Jun 26, 2019
@ajchili ajchili changed the title Add Visualization API endpoints Add Visualization API endpoint Jun 26, 2019
@ajchili
Copy link
Member Author

ajchili commented Jun 27, 2019

After investigating the current visualization components, I noticed that input paths are provided as a pattern rather than an array of strings as seen here and here. I believe it may be best to change the inputPaths parameter in the protobuf file to take in a single string to duplicate current behavior rather than an array of strings.


message Visualization {
// Output. Unique visualization ID. Generated by API server.
string id = 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would the ID be used? If not maybe it can be removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For predefined visualizations it may not be necessary. However, for custom visualizations we will need a way to differentiate them if we only have a single enum type to denote custom visualizations.

backend/api/visualization.proto Outdated Show resolved Hide resolved
These are required for the new roc curve and will become import for passing any parameters form a user to the visualization.
@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels Jul 1, 2019
@ajchili
Copy link
Member Author

ajchili commented Jul 2, 2019

/hold
Determining the best course of action for python kernel spawning latency.

@ajchili
Copy link
Member Author

ajchili commented Jul 9, 2019

/hold cancel
Determined best course of action for python kernel spawning latency. The go backend will manage a python kernel. This will remove the startup latency (roughly 6 seconds) involved with spawning a kernel per visualization.

@IronPan
Copy link
Member

IronPan commented Jul 10, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 377464f into kubeflow:master Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants