Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing some creds #1470

Merged
merged 2 commits into from
Jun 7, 2019
Merged

removing some creds #1470

merged 2 commits into from
Jun 7, 2019

Conversation

animeshsingh
Copy link
Contributor

@animeshsingh animeshsingh commented Jun 7, 2019

This change is Reviewable

@animeshsingh
Copy link
Contributor Author

@Ark-kun this should be a quick merge

@animeshsingh
Copy link
Contributor Author

/assign @Ark-kun

@Ark-kun
Copy link
Contributor

Ark-kun commented Jun 7, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor

Ark-kun commented Jun 7, 2019

/test kubeflow-pipeline-e2e-test

@k8s-ci-robot k8s-ci-robot merged commit a3e7a0a into kubeflow:master Jun 7, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Add mms support for custom spec

* Fix var name in utils package

* Remove support via componentExtension

* Check custom spec container env for mms spec

* Push utils test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants