Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sample test fix: software version error #146

Merged
merged 4 commits into from
Nov 8, 2018
Merged

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Nov 8, 2018

This change is Reviewable

@gaoning777 gaoning777 changed the title [WIP] used to check sample tests [WIP] used to check sample tests(no need to review or merge) Nov 8, 2018
@gaoning777 gaoning777 changed the title [WIP] used to check sample tests(no need to review or merge) sample test fix: software version error Nov 8, 2018
@qimingj
Copy link
Contributor

qimingj commented Nov 8, 2018

/lgtm

@qimingj
Copy link
Contributor

qimingj commented Nov 8, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qimingj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 81341d3 into master Nov 8, 2018
@gaoning777 gaoning777 deleted the ngao/check-sample-test branch November 8, 2018 02:10
@gaoning777
Copy link
Contributor Author

/test mlpipeline-presubmit-sample-test

Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Add a note about scale to zero in the dev guide

Add a note to explain why there may be no pods. If you dont run get pods immediately it is a little disconcerting to see no output (as it makes you think your install is broken)

* Address Nits

* Update DEVELOPER_GUIDE.md

fix grammar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants