Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Skip attributes with missing values during PipelineMeta serialization #1448

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Jun 5, 2019

Before:

{
  "name": "foo",
  "description": "",
  "inputs": [{"name": "tag", "description": "", "type": "", "default": null}],
  "outnputs": []
}

after:

{
  "name": "foo",
  "inputs": [{"name": "tag"}]
}

This change is Reviewable

@Ark-kun Ark-kun requested a review from gaoning777 June 5, 2019 23:17
@Ark-kun Ark-kun force-pushed the SDK---Skip-attributes-with-missing-values-during-PipelineMeta-serialization branch from a608fba to a64ca7a Compare June 5, 2019 23:18
@gaoning777
Copy link
Contributor

How about leaving the value as empty instead of skipping it?

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 6, 2019

/test kubeflow-pipeline-e2e-test

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 7, 2019

How about leaving the value as empty instead of skipping it?

Hmm. The intent for this PR was to skip the values that are not set or empty. I think that it's better to only produce the minimal output that has only the required information.

@Ark-kun Ark-kun force-pushed the SDK---Skip-attributes-with-missing-values-during-PipelineMeta-serialization branch from a64ca7a to 0f745f1 Compare August 26, 2019 20:49
@ajchili
Copy link
Member

ajchili commented Aug 26, 2019

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Aug 26, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b496720 into kubeflow:master Aug 27, 2019
@Ark-kun Ark-kun deleted the SDK---Skip-attributes-with-missing-values-during-PipelineMeta-serialization branch August 27, 2019 21:41
ajchili pushed a commit to ajchili/pipelines that referenced this pull request Aug 28, 2019
…zation (kubeflow#1448)

* SDK - Skip attributes with missing values during PipelineMeta serialization

* Fixed the tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants