Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build - Simplify python SDK package installation #1444

Merged

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Jun 5, 2019

There is no longer a need to install Java, download and run swagger-codegen etc.


This change is Reviewable

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 5, 2019

/test kubeflow-pipeline-e2e-test

1 similar comment
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 5, 2019

/test kubeflow-pipeline-e2e-test

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 5, 2019

/test kubeflow-pipeline-sample-test

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 5, 2019

/test kubeflow-pipeline-e2e-test

@gaoning777
Copy link
Contributor

/lgtm
Please check the sample test.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 6, 2019

/test kubeflow-pipeline-e2e-test

@Ark-kun Ark-kun force-pushed the Build---Simplify-sample-compilation branch from 75803a5 to a27e489 Compare June 6, 2019 19:46
@k8s-ci-robot k8s-ci-robot removed the lgtm label Jun 6, 2019
@gaoning777
Copy link
Contributor

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 7, 2019

Please check the sample test.

It's passing.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 7, 2019

/approve

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 7, 2019

/assign @IronPan Can you please take a look?

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 15, 2019

/cc @IronPan

@IronPan
Copy link
Member

IronPan commented Jun 17, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun, IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f477a4f into kubeflow:master Jun 17, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants