add default value type checking #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
resolving #1361 |
Ark-kun
reviewed
May 30, 2019
Ark-kun
reviewed
May 30, 2019
Ark-kun
reviewed
May 30, 2019
Ark-kun
reviewed
May 30, 2019
Ark-kun
reviewed
May 31, 2019
Ark-kun
reviewed
May 31, 2019
Ark-kun
reviewed
May 31, 2019
|
/lgtm |
|
/test kubeflow-pipeline-e2e-test |
1 similar comment
|
/test kubeflow-pipeline-e2e-test |
|
/test kubeflow-pipeline-e2e-test |
Ark-kun
reviewed
Jun 1, 2019
|
/lgtm |
Ark-kun
reviewed
Jun 3, 2019
|
/lgtm |
|
/approve |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaoning777, IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
* add validation for storageUri * add test for invalid storageURIs * add function to get protocols as an array of string * generate regex dynamically from list of protocol prefixes * updated storage uri error to contain protocols * Reduced repeated regex * Fixed regex * Added exported function to check if Prefix is supported given a list of prefixes * Updated storageURI validation to use same prefix check as inference service * Removed test cases that are invalid and updated error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the dsl compiler to type checking the default values if the type contains the json schema.
This change is