Require full function signatures #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yebrahim
force-pushed
the
yebrahim/tslint-signature
branch
from
1f93180 to
d65e0b8
Compare
yebrahim
changed the title
|
ping |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rileyjbauer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
added 2 commits
November 8, 2018 11:26
yebrahim
force-pushed
the
yebrahim/tslint-signature
branch
from
6c86e1f to
a9c04a6
Compare
|
/lgtm |
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
* fix golint install message * Fix copy paste error in verify-golint
HumairAK
referenced
this pull request
in red-hat-data-services/data-science-pipelines
Mar 11, 2024
HumairAK
referenced
this pull request
in red-hat-data-services/data-science-pipelines
Mar 11, 2024
…fb50b272e7e68285 [Snyk] Security upgrade alpine from 3.11 to 3.16.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes, added stricter boolean return type enforcement and missing awaits (that don't change any behavior as of now).
This change is