Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pretty print inputs and outputs json #1348

Merged
merged 2 commits into from
May 17, 2019
Merged

Pretty print inputs and outputs json #1348

merged 2 commits into from
May 17, 2019

Conversation

rileyjbauer
Copy link
Contributor

@rileyjbauer rileyjbauer commented May 16, 2019 •
edited by jlewi
Loading

Augments DetailsTable to parse and pretty-print component inputs/outputs when they are JSON strings

Before:
image

After:
image

This change is Reviewable

@neuromage
Copy link
Contributor

/lgtm

@rileyjbauer
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rileyjbauer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 38540d7 into kubeflow:master May 17, 2019
@rileyjbauer rileyjbauer deleted the pretty-print-input-output-json branch May 21, 2019 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IronPan IronPan Awaiting requested review from IronPan

@yebrahim yebrahim Awaiting requested review from yebrahim

Assignees

@neuromage neuromage

Labels
approved area/frontend lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rileyjbauer @neuromage @k8s-ci-robot