Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] minio client in API server can be configured with environment variables #1324

Conversation

eterna2
Copy link
Contributor

@eterna2 eterna2 commented May 14, 2019

Background

I am deploying multiple kubeflow pipelines in a multi-cloud environment (AWS and Azure), and I am using minio-gateway as a proxy to Azure blob storage.

I need to have configurable minio endpoint to support multiple kubeflow pipelines deployment. Currently, it is hard-coded to the kubeflow namespace.

Related PR

#1064 is part of my PR to make minio endpoint configurable from the kfp sdk.

Related issues

#1319

Changes

This PR exposes the minio parameters as environment variables which allows me to deploy kubeflow pipelines to other namespaces.

  • MINIO_ENDPOINT is composed from MINIO_HOST and MINIO_NAMESPACE so that we can do the following in the deployment yaml.
env:
  - name: MINIO_NAMESPACE
     valueFrom:
       fieldRef:
         fieldPath: "metadata.namespace"

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @eterna2. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@k8s-ci-robot
Copy link
Contributor

Hi @eterna2. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@IronPan
Copy link
Member

IronPan commented May 14, 2019

/lgtm
/approve

@IronPan
Copy link
Member

IronPan commented May 14, 2019

awesome! thank you

@IronPan
Copy link
Member

IronPan commented May 14, 2019

/approve cancel

@IronPan
Copy link
Member

IronPan commented May 14, 2019

do you mind adding a frontend patch in here
https://github.com/kubeflow/pipelines/tree/master/manifests/namespaced-install
that set the minio namespace env for frontend?
similar to ml-pipeline-persistenceagent-deployment-patch.yaml

@eterna2 eterna2 force-pushed the eterna2/configurable-minio-service-frontend branch from 24067ee to db187ad Compare May 14, 2019 14:26
@k8s-ci-robot k8s-ci-robot removed the lgtm label May 14, 2019
@eterna2
Copy link
Contributor Author

eterna2 commented May 14, 2019

@IronPan
Hey I have rebased with the latest HEAD with the manifest, and added the patch for pipeline-ui.

I also regenerated the namespaced-install.yaml with the updated kustomize config.

@rileyjbauer
Copy link
Contributor

/ok-to-test

@IronPan
Copy link
Member

IronPan commented May 14, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants