Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add patch for metric collection #1317

Merged
merged 1 commit into from
May 14, 2019
Merged

add patch for metric collection #1317

merged 1 commit into from
May 14, 2019

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented May 13, 2019 •
edited by jlewi
Loading

This change is Reviewable

hongye-sun
hongye-sun reviewed May 13, 2019
View reviewed changes
Copy link
Contributor

@hongye-sun hongye-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gaoning777
Copy link
Contributor Author

/approve

@gaoning777
Copy link
Contributor Author

@hongye-sun would you mind approving since I'm not the owner of this directory.

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@hongye-sun
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777, hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777, hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaoning777 gaoning777 merged commit 13d506c into kubeflow:master May 14, 2019
@gaoning777 gaoning777 deleted the metric-injestion branch May 14, 2019 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongye-sun hongye-sun hongye-sun left review comments

@animeshsingh animeshsingh Awaiting requested review from animeshsingh

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

Assignees

@hongye-sun hongye-sun

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaoning777 @hongye-sun @k8s-ci-robot