Shows link to Stackdriver logs if logs retrieval fails and cluster is running in GKE #1310
Conversation
|
Synced with Pascal that we will display two links because it is both too hacky to get the GKE cluster configuration and non-trivial. By the time, GKE default stackdriver is the new kubernetes stackdriver, we can switch to one link, then. |
Sounds good. I've updated the logs pane to include both links. |
|
/test kubeflow-pipeline-e2e-test |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rileyjbauer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rileyjbauer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Example UI:
Clicking on the link will take the user to the Stackdriver log viewer in GCP with a preset query to get just the logs for the relevant pod.
The changes in
RunDetails.test.tsxare mostly refactoring/moving. Three new tests are:shows warning banner and link to Stackdriver in logs area if fetching logs failed and cluster is in GKEshows error banner atop logs area if fetching logs failed and getProjectId failsshows error banner atop logs area if fetching logs failed and getClusterName failsRelated to #844
This change is