Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mpi job into arena launcher #1307

Merged
merged 19 commits into from
May 15, 2019
Merged

Conversation

cheyang
Copy link
Contributor

@cheyang cheyang commented May 10, 2019

  1. Split arena_launcher.py into multiple modules to make it easy to iterate
  2. Add mpi job to arena launcher
  3. Add mpi job sample

This change is Reviewable

@cheyang
Copy link
Contributor Author

cheyang commented May 12, 2019

/assign @Ark-kun

@wsxiaozhang
Copy link

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

@wsxiaozhang: changing LGTM is restricted to assignees, and only kubeflow/pipelines repo collaborators may be assigned issues.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@k8s-ci-robot
Copy link
Contributor

@wsxiaozhang: changing LGTM is restricted to assignees, and only kubeflow/pipelines repo collaborators may be assigned issues.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Ark-kun
Copy link
Contributor

Ark-kun commented May 14, 2019

Can you please remove the mpi_run.yaml pipeline file? I'm not sure it's used anywhere and the format is implementation detail that we'd like to hide.

Also, can you please use PNG for screenshots in future? It has better quality and smaller size.

Other than this
/lgtm

env=[], data=[], sync_source=None,
metrics=['Train-accuracy:PERCENTAGE'],
arena_image='cheyang/arena_launcher:v0.6',
arena_image='cheyang/arena_launcher:v0.7',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my pet peeve :-) Let`s try and move away from docker repos tied to an individual - doesn't give confidence over the maintainability of the project.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, do you have any guidance?

First, install the necessary Python Packages
```shell
pip3 install http://kubeflow.oss-cn-beijing.aliyuncs.com/kfp/0.1.16/kfp.tar.gz --upgrade
pip3 install http://kubeflow.oss-cn-beijing.aliyuncs.com/kfp-arena/kfp-arena-0.6.tar.gz --upgrade
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason these python packages cannot submitted to universal python package library?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I give this link because it's accessible from China. I will try to see how submit to universal python package library, thanks.

@cheyang
Copy link
Contributor Author

cheyang commented May 14, 2019

/ping @Ark-kun, I've updated according to your comments. Thanks.

@Ark-kun
Copy link
Contributor

Ark-kun commented May 15, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun, wsxiaozhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun, wsxiaozhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8495eb1 into kubeflow:master May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants