-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cops and rops pipeline attributes #1298
Conversation
Hi @elikatsis. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @elikatsis. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
b7d7b77
to
20527a3
Compare
* Remove the separated dictionaries for ContainerOps and ResourceOps * Fix the sanitization performed by the compiler to iterate through ops dict and do type-check for the special fields file_outputs and attribute_outputs Signed-off-by: Ilias Katsakioris <elikatsis@arrikto.com>
20527a3
to
2bb267e
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dict and do type-check for the special fields file_outputs and
attribute_outputs
I found a bug which has to do with
PipelineParam
hashing.__hash__
method ofPipelineParam
now usespattern
attribute too.If a
PipelineParam
was found twice in an Op, e.g. inarguments
and involumes
, having different patterns messed theinputs
attribute (which usesset()
on the extractedPipelineParam
s).I will open a separate PR for this.
This change is