Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cops and rops pipeline attributes #1298

Merged
merged 1 commit into from
May 10, 2019

Conversation

elikatsis
Copy link
Member

@elikatsis elikatsis commented May 8, 2019

  • Remove the separated dictionaries for ContainerOps and ResourceOps
  • Fix the sanitization performed by the compiler to iterate through ops
    dict and do type-check for the special fields file_outputs and
    attribute_outputs

I found a bug which has to do with PipelineParam hashing.
__hash__ method of PipelineParam now uses pattern attribute too.
If a PipelineParam was found twice in an Op, e.g. in arguments and in volumes, having different patterns messed the inputs attribute (which uses set() on the extracted PipelineParams).

I will open a separate PR for this.


This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @elikatsis. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Hi @elikatsis. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elikatsis elikatsis changed the title Remove cops and rops pipeline attributes Remove cops and rops pipeline attributes & Fix PipelineParam hashing bug May 8, 2019
@elikatsis elikatsis force-pushed the remove-cops-rops branch 2 times, most recently from b7d7b77 to 20527a3 Compare May 8, 2019 17:40
@elikatsis elikatsis changed the title Remove cops and rops pipeline attributes & Fix PipelineParam hashing bug Remove cops and rops pipeline attributes May 8, 2019
* Remove the separated dictionaries for ContainerOps and ResourceOps
* Fix the sanitization performed by the compiler to iterate through ops
  dict and do type-check for the special fields file_outputs and
  attribute_outputs

Signed-off-by: Ilias Katsakioris <elikatsis@arrikto.com>
@elikatsis elikatsis force-pushed the remove-cops-rops branch from 20527a3 to 2bb267e Compare May 8, 2019 17:42
@Ark-kun
Copy link
Contributor

Ark-kun commented May 8, 2019

/lgtm

@Ark-kun
Copy link
Contributor

Ark-kun commented May 8, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b675e02 into kubeflow:master May 10, 2019
@elikatsis elikatsis deleted the remove-cops-rops branch March 9, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants