Fix watson train component

[mpoqq]

Add scheme to cos_endpoint for watson client and change deprecated author_email to author_name.
#1254 point 3.

---

This change is 

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[k8s-ci-robot]

Hi @mpoqq. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Hi @mpoqq. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[mpoqq]

/assign @animeshsingh

[Tomcli]

I think overall it looks good to me, but it would be nice if we can make sure we get rid of the http:// scheme before passing to the Minio client. e.g.

import re
url = re.compile(r"https?://")
cos_endpoint = url.sub('', cos_endpoint)

[animeshsingh]

Another option could be to just make the prefix a var, http or https (based on user`s setting). Otherwise /lgtm

[animeshsingh]

Quick change needed on how to represent the "https" prefix.

[mpoqq]

I see your points, but if we configure the endpoint over two ways (creds.ini and parameter) it is maybe confuse. How about we say the endpoint must have a scheme and than do something like this:

from urllib.parse import urlsplit
parts = urlsplit(endpoint_url)
endpoint_without_scheme = parts.hostname
endpoint_with_scheme = parts.geturl()

(it is equivalent what watson client api does here)

[animeshsingh]

+1. Go ahead and test it once under different scenarios, and update the PR.

[animeshsingh]

Hi @mpoqq - I think there is a misunderstanding, and we can slack somewhere. I definitely dont want us to shift to ibm cos sdk - we want to stick with minio as the client.

[mpoqq]

Hi @animeshsingh, sorry for the misinterpretation. I send you a direct message in the kubeflow slack.

[mpoqq]

@animeshsingh friendly reminder =)

[Tomcli]

/lgtm

[k8s-ci-robot]

@Tomcli: changing LGTM is restricted to assignees, and only kubeflow/pipelines repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[animeshsingh]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: animeshsingh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• components/ibm-components/OWNERS [animeshsingh]
• samples/ibm-samples/OWNERS [animeshsingh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment