SDK/Client - Supporting pipeline packages with multiple files #1207
Conversation
Ark-kun
force-pushed
the
SDK/Client---Supporting-pipeline-packages-with-multiple-files
branch
from
b4d9678
to
9bb544a
Compare
…with-multiple-files
|
/test kubeflow-pipeline-sample-test |
| else: | ||
| if len(yaml_files) == 1: | ||
| return yaml_files[0] | ||
| raise ValueError('Invalid package. There is no pipeline.yaml file and there are multiple yaml files.') |
There was a problem hiding this comment.
not sure if the error message raised here is what you are trying to express
so instead of 'Invalid package. There is no pipeline.yaml file and there are multiple yaml files.'
shouldn't it be 'Invalid package. There are multiple yaml files.'
There was a problem hiding this comment.
No. The whole goal of this PR is to support packages containing multiple .yaml files. In that case one of them must be called pipeline.yaml.
|
Ping @hongye-sun |
|
Ha, make me an approver @Ark-kun - some of these small ones can go faster, and more distributed load :-) |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ark-kun
deleted the
SDK/Client---Supporting-pipeline-packages-with-multiple-files
branch
This change is