Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK/Tests - Properly closing tar files opened for writing #1169

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Apr 15, 2019


This change is Reviewable

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 15, 2019

/test kubeflow-pipeline-e2e-test

@gaoning777
Copy link
Contributor

/test kubeflow-pipeline-sample-test

@gaoning777
Copy link
Contributor

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 23, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b588ba0 into kubeflow:master Apr 23, 2019
@Ark-kun Ark-kun deleted the SDK/Tests---Properly-closing-tar-files-opened-for-writing branch April 23, 2019 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants