Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backend): updated deprecated grpc func #11603

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

dandawg
Copy link
Contributor

@dandawg dandawg commented Feb 7, 2025

Description of your changes:
The go func grpc.WithInsecure() was deprecated. This replaces the deprecated code line.

Checklist:

Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Signed-off-by: Daniel Dowler <12484302+dandawg@users.noreply.github.com>
@dandawg dandawg force-pushed the fix-grpc-func-deprecation branch from a05d345 to f2e73e8 Compare February 10, 2025 19:15
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbelmiro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 65d1d79 into kubeflow:master Feb 11, 2025
32 checks passed
@dandawg dandawg deleted the fix-grpc-func-deprecation branch February 12, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants