Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tests): added makefiles for testing workflow tests locally #11509

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore(tests): added makefiles for testing workflow tests locally #11509

wants to merge 2 commits into from
+409 −235

Conversation

chahatsagarmain
Copy link
Contributor

@chahatsagarmain chahatsagarmain commented Jan 11, 2025 •
edited
Loading

Description of your changes:
Issue #11494
Added makefiles for tests and setup each test locally .

Checklist:

@google-oss-prow Google OSS Prow
Copy link

Hi @chahatsagarmain. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

DharmitD
DharmitD reviewed Jan 12, 2025
View reviewed changes
Copy link
Contributor

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@google-oss-prow google-oss-prow bot added the lgtm label Jan 12, 2025
@DharmitD
Copy link
Contributor

/ok-to-test

@hbelmiro
Copy link
Contributor

@anishasthana you may like to review this.

@jgarciao
Copy link

Could you document how to launch the tests in https://github.com/kubeflow/pipelines/blob/master/test/README.md ?

@hbelmiro
Copy link
Contributor

@chahatsagarmain I added one more item to the issue's acceptance criteria.

  • Workflows need to be updated to use the new make targets

@google-oss-prow google-oss-prow bot removed the lgtm label Jan 19, 2025
@mahdikhashan
Copy link

hello @chahatsagarmain , following up with our chat on slack, would you please make sure that this command (make test-requirements) is addressed in the makefile correctly?

related commit in parallel pr:

ce7f54c

it should point to the test-requirements.sh in the dir .github/resources/scripts/.

thanks for your collaboration in advance.

cc: @hbelmiro

hbelmiro
hbelmiro reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chahatsagarmain please don't forget the actions.

.github/workflows/presubmit-backend.yml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the missing .github/workflows/presubmit-backend.yml to on.pull_request.paths.

.github/workflows/sdk-component-yaml.yml Outdated
@@ -53,4 +53,4 @@ jobs:
run: pip install -r ./test/sdk-execution-tests/requirements.txt

- name: Run component YAML tests
run: ./test/presubmit-component-yaml.sh
run: make sdk-component-yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed the setup for this one.

.github/workflows/sdk-execution.yml Outdated
export KFP_ENDPOINT="http://localhost:8888"
export TIMEOUT_SECONDS=2700
pytest ./test/sdk-execution-tests/sdk_execution_tests.py --asyncio-task-timeout $TIMEOUT_SECONDS
make sdk-execution
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed the setup for this one.

.github/workflows/sdk-yapf.yml Outdated
@@ -33,4 +33,4 @@ jobs:
run: pip install yapf

- name: Run YAPF SDK Tests
run: ./test/presubmit-yapf-sdk.sh
run: make sdk-yapf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed the setup for this one.

Makefile Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename them to have test- in the beginning of their names so it will be easier for contributors to find them.
For example, backend-test-flip-coin -> test-backend-flip-coin.

@hbelmiro
Copy link
Contributor

/ok-to-test

@github-actions GitHub Actions
Copy link

Approvals successfully granted for pending runs.

@hbelmiro hbelmiro mentioned this pull request Jan 20, 2025
Closed
2 tasks
@hbelmiro
Copy link
Contributor

hello @chahatsagarmain , following up with our chat on slack, would you please make sure that this command (make test-requirements) is addressed in the makefile correctly?

related commit in parallel pr:

ce7f54c

it should point to the test-requirements.sh in the dir .github/resources/scripts/.

thanks for your collaboration in advance.

cc: @hbelmiro

@mahdikhashan as per #11512 (comment), you need to add the new target in your PR, otherwise it won't pass the CI and can't get merged.

@google-oss-prow google-oss-prow bot added size/XL and removed size/L labels Jan 20, 2025
@hbelmiro
Copy link
Contributor

/ok-to-test

@github-actions GitHub Actions
Copy link

Approvals successfully granted for pending runs.

@hbelmiro
Copy link
Contributor

/ok-to-test

@github-actions GitHub Actions
Copy link

Approvals successfully granted for pending runs.

@hbelmiro
Copy link
Contributor

/ok-to-test

@github-actions GitHub Actions
Copy link

Approvals successfully granted for pending runs.

@hbelmiro
Copy link
Contributor

/ok-to-test

@github-actions GitHub Actions
Copy link

Approvals successfully granted for pending runs.

@chahatsagarmain
Copy link
Contributor Author

@hbelmiro all test pass now but frontend test is failing across runs ( even on master branch )

@hbelmiro
Copy link
Contributor

Awesome! Thank you @chahatsagarmain.
I'll review it as soon as I have time.
You can ignore the frontend tests for now.

@hbelmiro
Copy link
Contributor

hbelmiro commented Feb 2, 2025

/ok-to-test

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2025

Approvals successfully granted for pending runs.

hbelmiro
hbelmiro reviewed Feb 3, 2025
View reviewed changes
.github/workflows/e2e-test.yml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed the frontend tests.

.github/workflows/frontend.yml
Comment on lines -27 to -31
- name: Clean npm cache
run: npm cache clean --force

- name: Install dependencies
run: cd ./frontend && npm ci
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a specific make setup... target for this?

@hbelmiro
Copy link
Contributor

hbelmiro commented Feb 3, 2025

@chahatsagarmain I think after the two above comments we're good to merge it. Can you please squash your commits before we merge it?

@chahatsagarmain
make file commands to test locally and workflow changes
3ec9555 
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
@google-oss-prow google-oss-prow bot added size/XXL and removed size/XL labels Feb 4, 2025
@chahatsagarmain
Merge branch 'master' into makefile
2410cac 
Signed-off-by: chahat sagar <109112505+chahatsagarmain@users.noreply.github.com>
@google-oss-prow google-oss-prow bot added size/XL and removed size/XXL labels Feb 4, 2025
hbelmiro
hbelmiro approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

cc @HumairAK

@google-oss-prow google-oss-prow bot added the lgtm label Feb 4, 2025
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hbelmiro
Once this PR has been reviewed and has the lgtm label, please assign zijianjoy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DharmitD DharmitD DharmitD left review comments

@hbelmiro hbelmiro hbelmiro approved these changes

@HumairAK HumairAK Awaiting requested review from HumairAK

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees

@hbelmiro hbelmiro

@DharmitD DharmitD

Labels
lgtm ok-to-test size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chahatsagarmain @DharmitD @hbelmiro @jgarciao @mahdikhashan