Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): add PipelineConfig to api to re-implement pipeline-level config #11333

Merged
merged 1 commit into from
Oct 29, 2024
Merged

feat(api): add PipelineConfig to api to re-implement pipeline-level config #11333

merged 1 commit into from
Oct 29, 2024

Conversation

gregsheremeta
Copy link
Contributor

@gregsheremeta gregsheremeta commented Oct 28, 2024 •
edited
Loading

Description of your changes:

KFP v1 supported setting pipeline-level configuration via a PipelineConf class. This class was deprecated and no replacement was added to KFP v2.

add new PipelineConfig message in the api to support setting pipeline-level configuration in KFP v2.

companion to #11112. #11333 has to be merged first.

Checklist:

@gregsheremeta
add PipelineConfig to api to re-implement pipeline-level config
009132a 
KFP v1 supported setting pipeline-level configuration via a
`PipelineConf` class. This class was deprecated and no replacement
was added to KFP v2.

add new PipelineConfig message in the api to support setting
pipeline-level configuration in KFP v2.

Signed-off-by: Greg Sheremeta <gshereme@redhat.com>
@gregsheremeta gregsheremeta mentioned this pull request Oct 28, 2024
Merged
1 task
@github-actions github-actions bot added the ci-passed All CI tests on a pull request have passed label Oct 28, 2024
DharmitD
DharmitD reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Oct 29, 2024
@rimolive
Copy link
Member

/lgtm

hbelmiro
hbelmiro reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

companion to #11112

I suggest complementing this comment to tell that this PR has to be merged before #11112.

@gregsheremeta
Copy link
Contributor Author

I suggest complementing this comment to tell that this PR has to be merged before #11112.

done

@HumairAK
Copy link
Collaborator

/lgtm
/approve

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit c2f5649 into kubeflow:master Oct 29, 2024
13 checks passed
@gregsheremeta
Copy link
Contributor Author

Note for anyone looking at this or relying on it: I'm not positive that it was ok to bump the version here, but I'm looking into it. I see other examples where we've done a similar bump. I've added this as a topic for the next SIG meeting.

@HumairAK
Copy link
Collaborator

HumairAK commented Nov 4, 2024

fyi @chensun

@gregsheremeta
Copy link
Contributor Author

Note for anyone looking at this or relying on it: I'm not positive that it was ok to bump the version here, but I'm looking into it. I see other examples where we've done a similar bump. I've added this as a topic for the next SIG meeting.

Cancel the alarm. It's fine. My full write up on why:

November 5, 2024 - protoc versions - Google Docs
https://docs.google.com/document/d/19NF4NiZToLvP6Vp8fDleSsdkyK5fjv_jd8k1FCflyLQ/edit?tab=t.0

We can go over it at tomorrow's meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DharmitD DharmitD DharmitD left review comments

@hbelmiro hbelmiro hbelmiro left review comments

@connor-mccarthy connor-mccarthy Awaiting requested review from connor-mccarthy

@ouadakarim ouadakarim Awaiting requested review from ouadakarim

Assignees

@rimolive rimolive

@HumairAK HumairAK

@hbelmiro hbelmiro

@DharmitD DharmitD

Labels
approved ci-passed All CI tests on a pull request have passed lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gregsheremeta @rimolive @HumairAK @hbelmiro @DharmitD