WIP: test: Re-enable KFP Dockerfile-CLI component SDK unit test #11305
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
DharmitD
changed the title
DharmitD
changed the title
DharmitD
changed the title
DharmitD
force-pushed
the
sdk-failed-test
branch
from
c42c14d
to
b87eee2
Compare
sdk/python/kfp/cli/component_test.py
Outdated
| @@ -608,7 +605,7 @@ def test_dockerfile_can_contain_custom_kfp_package(self): | |||
| file_start = textwrap.dedent('''\ | |||
| # Generated by KFP. | |||
|
|
|||
| FROM python:3.9 | |||
| FROM python:3.12 | |||
There was a problem hiding this comment.
based on your comment, it seems like it works for 3.9, if so maybe it's best if we keep this consistent with the rest of the tests and use 3.9
There was a problem hiding this comment.
Unfortunately it doesn't. I'd executed a subprocess previously in my virtual environment and then ran this test which is why it went through.
I replicated this on a fresh venv and the missing wheel file error still comes up.
Removed the skip unit test decorator that was previously added to bypass the test due to failure (referencing issue kubeflow#11038). The issue reported in kubeflow#11038 was caused due to the Dockerfile referencing to Python 3.7. With the Python version updated to 3.9, the test now passes consistently. This commit re-enables the test to ensure proper validation of Dockerfile creation and KFP package. Signed-off-by: ddalvi <ddalvi@redhat.com>
DharmitD
force-pushed
the
sdk-failed-test
branch
from
b87eee2
to
c0f0486
Compare
Removed the skip unit test decorator that was previously added to bypass the test due to failure (referencing issue #11038).
The issue reported in #11038 was caused due to the Dockerfile referencing to Python 3.7. With the Python version updated to 3.9 (done as part of this commit), the test now passes consistently. This commit re-enables the test to ensure proper validation of Dockerfile creation and KFP package.
Description of your changes:
Checklist: