Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix CI by adding a dependency of python/sdk for the e2e-test #11221

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

rimolive
Copy link
Member

@rimolive rimolive commented Sep 17, 2024

Description of your changes:
This PR is also reverting the files deletion that are required to run CI tests.

Checklist:

@diegolovison
Copy link
Contributor

diegolovison commented Sep 17, 2024

Suggestion to fix it properly.

  • Update the commit message: fix CI by adding a dependency of python/sdk for the e2e-test
  • Edit .github/workflows/e2e-test.yml and add - 'sdk/python/**' under paths
  • Your PR will fail
  • Add the files back
  • Your PR will work

The approach above is going to prevent this error from happening again. ( if it worked )

image

@rimolive rimolive changed the title chore: Revert files deletion chore: fix CI by adding a dependency of python/sdk for the e2e-test Sep 17, 2024
Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com>
@diegolovison
Copy link
Contributor

/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rimolive
Copy link
Member Author

/rerun-all

@google-oss-prow google-oss-prow bot merged commit ba006bd into kubeflow:master Sep 17, 2024
22 checks passed
sefgsefg pushed a commit to sefgsefg/pipelines that referenced this pull request Sep 18, 2024
…ubeflow#11221)

Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com>
Signed-off-by: sefgsefg <sefgsefg@gmail.com>
sefgsefg pushed a commit to sefgsefg/pipelines that referenced this pull request Sep 18, 2024
…ubeflow#11221)

Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com>
Signed-off-by: sefgsefg <sefgsefg@gmail.com>
@gregsheremeta
Copy link
Contributor

too late now, but in the future add a note to the commit along the lines of partially reverts <git sha> so we can more easily trace the lineage of the recreated files.

R3hankhan123 pushed a commit to R3hankhan123/pipelines that referenced this pull request Sep 20, 2024
sefgsefg pushed a commit to sefgsefg/pipelines that referenced this pull request Sep 20, 2024
zed546213 pushed a commit to zed546213/pipelines that referenced this pull request Sep 23, 2024
…ubeflow#11221)

Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com>
Signed-off-by: zed546213 <zed546213@gmail.com>
chris454656 pushed a commit to chris454656/pipelines that referenced this pull request Sep 24, 2024
…ubeflow#11221)

Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com>
Signed-off-by: chris <chris20120826@gmail.com>
boarder7395 pushed a commit to boarder7395/pipelines that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants