Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): Fixes V1 Run detail unnecessary reloading. Fixes #10590 #11214

Merged
merged 1 commit into from
Sep 16, 2024
Merged

fix(ui): Fixes V1 Run detail unnecessary reloading. Fixes #10590 #11214

merged 1 commit into from
Sep 16, 2024

Conversation

quinnovator
Copy link
Contributor

@quinnovator quinnovator commented Sep 15, 2024 •
edited
Loading

Description of your changes:
This PR addresses #10590. V1 Run details were unexpectedly reloading when users navigated away from the page.

This is because the loading state is derived from a query that happens in RunDetailsRouter.tsx, which then determines whether to show the loading message or RunDetails.tsx. When the loading state occurs, the RunDetails component is unmounted because of this condition.

To address this issue, I have established a prop for EnhancedRunDetails called isLoading. This prop is derived from the same query as before, but the condition is now leveraged within the render method of the RunDetails component itself, therefore preventing the component from unmounting.

Checklist:

@quinnovator
Make loading state local to EnhancedRunDetails
bdb6f44 
Signed-off-by: Jack Quinn <jack@jq.codes>
@google-oss-prow Google OSS Prow
Copy link

Hi @quinnovator. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@quinnovator
Copy link
Contributor Author

CC: @droctothorpe

@quinnovator quinnovator mentioned this pull request Sep 15, 2024
Closed
@droctothorpe
Copy link
Contributor

/ok-to-test

chensun
chensun approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Sep 16, 2024
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit eee095e into kubeflow:master Sep 16, 2024
9 checks passed
@TheKevJames TheKevJames mentioned this pull request Sep 17, 2024
Merged
1 task
sefgsefg pushed a commit to sefgsefg/pipelines that referenced this pull request Sep 18, 2024
@quinnovator @sefgsefg
fix(ui): Fixes V1 Run detail unnecessary reloading. Fixes kubeflow#10590
f3df7a5 
 (kubeflow#11214)

Signed-off-by: Jack Quinn <jack@jq.codes>
Signed-off-by: sefgsefg <sefgsefg@gmail.com>
sefgsefg pushed a commit to sefgsefg/pipelines that referenced this pull request Sep 18, 2024
@quinnovator @sefgsefg
fix(ui): Fixes V1 Run detail unnecessary reloading. Fixes kubeflow#10590
98e55d0 
 (kubeflow#11214)

Signed-off-by: Jack Quinn <jack@jq.codes>
Signed-off-by: sefgsefg <sefgsefg@gmail.com>
R3hankhan123 pushed a commit to R3hankhan123/pipelines that referenced this pull request Sep 20, 2024
@quinnovator @R3hankhan123
fix(ui): Fixes V1 Run detail unnecessary reloading. Fixes kubeflow#10590
2b86ed1 
 (kubeflow#11214)

Signed-off-by: Jack Quinn <jack@jq.codes>
sefgsefg pushed a commit to sefgsefg/pipelines that referenced this pull request Sep 20, 2024
@quinnovator @sefgsefg
fix(ui): Fixes V1 Run detail unnecessary reloading. Fixes kubeflow#10590
2594e5f 
 (kubeflow#11214)

Signed-off-by: Jack Quinn <jack@jq.codes>
zed546213 pushed a commit to zed546213/pipelines that referenced this pull request Sep 23, 2024
@quinnovator @zed546213
fix(ui): Fixes V1 Run detail unnecessary reloading. Fixes kubeflow#10590
70001c5 
 (kubeflow#11214)

Signed-off-by: Jack Quinn <jack@jq.codes>
Signed-off-by: zed546213 <zed546213@gmail.com>
chris454656 pushed a commit to chris454656/pipelines that referenced this pull request Sep 24, 2024
@quinnovator @chris454656
fix(ui): Fixes V1 Run detail unnecessary reloading. Fixes kubeflow#10590
3d79d30 
 (kubeflow#11214)

Signed-off-by: Jack Quinn <jack@jq.codes>
Signed-off-by: chris <chris20120826@gmail.com>
boarder7395 pushed a commit to boarder7395/pipelines that referenced this pull request Oct 17, 2024
@quinnovator @boarder7395
fix(ui): Fixes V1 Run detail unnecessary reloading. Fixes kubeflow#10590
292b99c 
 (kubeflow#11214)

Signed-off-by: Jack Quinn <jack@jq.codes>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chensun chensun chensun approved these changes

@HumairAK HumairAK Awaiting requested review from HumairAK

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees

@chensun chensun

Labels
approved lgtm ok-to-test size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quinnovator @droctothorpe @chensun