update katib laucher #1118
update katib laucher #1118
Conversation
1. sync up since katib directory org changed 2. add option deleteafterdone
|
/assign @vicaire |
| - {name: Request count, type: Integer, default: 1, description: 'Number of requests to the suggestion service.'} | ||
| - {name: Metrics names, type: String, description: 'List of metric names (comma-delimited).'} | ||
| - {name: Parameter configs, type: YAML, default: '', description: 'Parameter configs (YAML/JSON format).'} | ||
| - {name: NAS config, type: YAML, default: '', description: 'NAS config (YAML/JSON format).'} | ||
| - {name: Worker template path, type: String, default: '', description: 'Worker spec.'} | ||
| - {name: Metrics collector template path, type: String, default: '', description: 'Metrics collector spec.'} | ||
| - {name: Suggestion spec, type: YAML, default: '', description: 'Suggestion spec (YAML/JSON format).'} | ||
| - {name: StudyJob timeout minutes, type: Integer, default: '10', description: 'Time in minutes to wait for the StudyJob to complete'} | ||
| - {name: StudyJob timeout minutes, type: Integer, default: '10', description: 'Time in minutes to wait for the StudyJob to complete.'} | ||
| - {name: Delete StudyJob flag, type: String, default: 'True', description: 'When StudyJob done, delete the StudyJob if it is True.'} |
There was a problem hiding this comment.
| - {name: Delete StudyJob flag, type: String, default: 'True', description: 'When StudyJob done, delete the StudyJob if it is True.'} | |
| - {name: Delete finished job, type: Boolean, default: 'True', description: 'Whether to delete the job after it's finished.'} |
| @@ -34,5 +35,6 @@ implementation: | |||
| --mcollectortemplatepath, {inputValue: Metrics collector template path}, | |||
| --suggestionspec, {inputValue: Suggestion spec}, | |||
| --studyjobtimeoutminutes, {inputValue: StudyJob timeout minutes}, | |||
| --deleteafterdone, {inputValue: Delete StudyJob flag}, | |||
There was a problem hiding this comment.
| --deleteafterdone, {inputValue: Delete StudyJob flag}, | |
| --deleteafterdone, {inputValue: Delete finished job}, |
| @@ -34,6 +34,7 @@ def kubeflow_studyjob_launcher_op(name, namespace, optimizationtype, objectiveva | |||
| "--mcollectortemplatepath", mcollectortemplatepath, | |||
| "--suggestionspec", suggestionspec, | |||
| "--outputfile", output_file, | |||
| "--deleteafterdone", delete, | |||
| @@ -39,6 +39,14 @@ def yamlOrJsonStr(str): | |||
| def strToList(str): | |||
| return str.split(",") | |||
|
|
|||
| def str2bool(v): | |||
There was a problem hiding this comment.
from distutils.util import strtobool
| @@ -121,6 +129,9 @@ def main(argv=None): | |||
| parser.add_argument('--outputfile', type=str, | |||
| default='/output.txt', | |||
| help='The file which stores the best trial of the studyJob.') | |||
| parser.add_argument('--deleteafterdone', type=str2bool, | |||
|
@Ark-kun thanks for your comment. Updated |
Can you please quote 'True' and improve the description: #1118 (comment) |
sorry, miss the comment. Updated now. Thanks |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This change is