Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fixed kfp-runtime-tests to run on master branch #11158

Merged
merged 1 commit into from
Sep 6, 2024
Merged

test: Fixed kfp-runtime-tests to run on master branch #11158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions sdk/runtime_tests/execute_commands_args_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,6 @@ class RuntimeTestConfig:
)
]

PULL_NUMBER = None


def run_commands_and_args(
config: RuntimeTestConfig,
Expand All @@ -116,16 +114,8 @@ def run_commands_and_args(
# so much that it renders the test less valuable, since the
# commands/args resemble the true runtime commands/args less well
# prefer the less invasive approach of installing from a PR
global PULL_NUMBER
if PULL_NUMBER is None:
if 'PULL_NUMBER' in os.environ:
PULL_NUMBER = os.environ['PULL_NUMBER']
else:
PULL_NUMBER = input(
"Please provide the PR number for the kubeflow/pipelines PR that contains the changes you'd like to test:"
)

kfp_package_path = f'git+https://github.com/kubeflow/pipelines.git@refs/pull/{PULL_NUMBER}/merge#subdirectory=sdk/python'

kfp_package_path = 'sdk/python'
command_and_args = [
re.sub(r"'kfp==(\d+).(\d+).(\d+)(-[a-z]+.\d+)?'", kfp_package_path,
cmd) for cmd in command_and_args
Expand Down
Loading