Updated the "Basic - Retry" sample #1111
Conversation
Modernized the sample pipeline code.
|
/test kubeflow-pipeline-e2e-test The sample tests have passed. https://prow.k8s.io/pr-history/?org=kubeflow&repo=pipelines&pr=1111 |
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| import kfp.compiler as compiler | ||
| compiler.Compiler().compile(retry_sample_pipeline, __file__ + '.zip') | ||
| kfp.compiler.Compiler().compile(retry_sample_pipeline, __file__ + '.zip') |
There was a problem hiding this comment.
Why does this compiler appears twice? confusing here - " kfp.compiler.Compiler().compile'
There was a problem hiding this comment.
It appears three times:
- Module name
- Class name
- Method name
I guess @qimingj's idea was that the Compiler class instance might store some configuration that you prepare before compiling the pipeline.
It does not serves a useful purpose at this moment and should probably be simplified to a single function like create_pipeline_package_from_func.
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Modernized the sample pipeline code.
/assign @gaoning777 @hongye-sun
/label area/components
This change is