Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed mentions of ark7 in tests #111

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Removed mentions of ark7 in tests #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/python/tests/components/test_data/python_add.component.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ outputs:
- {name: Output, type: float}
implementation:
dockerContainer:
image: ark7/python-fire
image: python:3.5
command:
- python
- -c
Expand Down
8 changes: 4 additions & 4 deletions sdk/python/tests/components/test_python_op.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def add_two_numbers_decorated(a: float, b: float) -> float:
'''Returns sum of two arguments'''
return a + b

@comp.python_op(base_image='ark7/python-fire')
@comp.python_op(base_image='python:3.5')
def add_two_numbers_decorated_with_parameters(a: float, b: float) -> float:
'''Returns sum of two arguments'''
return a + b
Expand Down Expand Up @@ -123,7 +123,7 @@ def add_two_numbers_indented_decorated(a: float, b: float) -> float:
self.helper_test_2_in_1_out_component_using_local_call(add_two_numbers, add_two_numbers_indented_decorated)

def test_indented_decorated_with_parameters_func_to_container_op_local_call(self):
@comp.python_op(base_image='ark7/python-fire')
@comp.python_op(base_image='python:3.5')
def add_two_numbers_indented_decorated_with_parameters(a: float, b: float) -> float:
'''Returns sum of two arguments'''
return a + b
Expand Down Expand Up @@ -211,13 +211,13 @@ def add(a: float, b: float) -> float:
subtract_component_file = str(Path(temp_dir_name).joinpath('subtract.component.yaml'))

#Converting the function to a component. Instantiate it to create a pipeline task (ContaineOp instance)
add_op = comp.func_to_container_op(add, base_image='ark7/python-fire', output_component_file=add_component_file)
add_op = comp.func_to_container_op(add, base_image='python:3.5', output_component_file=add_component_file)

#Checking that the component artifact is usable:
add_op2 = comp.load_component_from_file(add_component_file)

#Using decorator to perform the same thing (convert function to a component):
@python_op(base_image='ark7/python-fire', output_component_file=subtract_component_file)
@python_op(base_image='python:3.5', output_component_file=subtract_component_file)
def subtract_op(a: float, b: float) -> float:
'''Returns difference between two arguments'''
return a - b
Expand Down