Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add-Create-Experiment-button-when-selecting-experiement-#5737 #11060

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add-Create-Experiment-button-when-selecting-experiement-#5737 #11060

wants to merge 5 commits into from

Conversation

ElayAharoni
Copy link
Contributor

feat(frontend): add create experiment button when selecting experiment. Fixes #5737

Add-Create-Experiment-button-when-selecting-experiement-kubeflow#5737
19607a2 
Signed-off-by: Elay Aharoni (EXT-Nokia) <elay.aharoni.ext@nokia.com>
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zijianjoy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow Google OSS Prow
Copy link

Hi @ElayAharoni. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hbelmiro
Copy link
Contributor

/ok-to-test
/rerun-all

Elay Aharoni (EXT-Nokia) added 2 commits July 31, 2024 22:18
Add-Create-Experiment-button-when-selecting-experiement-kubeflow#5737
3289427 
Signed-off-by: Elay Aharoni (EXT-Nokia) <elay.aharoni.ext@nokia.com>
Merge remote-tracking branch 'origin/Add-Create-Experiment-button-whe…
817d33c 
…n-selecting-experiement-#5737' into Add-Create-Experiment-button-when-selecting-experiement-kubeflow#5737

# Conflicts:
#	frontend/src/pages/NewRunV2.tsx
#	frontend/src/pages/functional_components/NewExperimentFC.tsx
@google-oss-prow google-oss-prow bot added size/L and removed size/M labels Jul 31, 2024
@ElayAharoni
Copy link
Contributor Author

i fixed the formatting of the code, please if i can have a second review. thanks

@hbelmiro
Copy link
Contributor

hbelmiro commented Aug 1, 2024

/rerun-all

Elay Aharoni (EXT-Nokia) added 2 commits August 1, 2024 14:47
Merge remote-tracking branch 'origin/Add-Create-Experiment-button-whe…
a765a1e 
…n-selecting-experiement-#5737' into Add-Create-Experiment-button-when-selecting-experiement-kubeflow#5737
Merge remote-tracking branch 'origin/Add-Create-Experiment-button-whe…
27b8be6 
…n-selecting-experiement-#5737' into Add-Create-Experiment-button-when-selecting-experiement-kubeflow#5737
@ElayAharoni
Copy link
Contributor Author

ElayAharoni commented Aug 1, 2024 •
edited
Loading

thanks, i had one more lint issue that i missed.. can you please retrigger the tests whenever you can?
or am i authorized to do so myself?

@hbelmiro
Copy link
Contributor

hbelmiro commented Aug 1, 2024 •
edited
Loading

/rerun-all

@ElayAharoni you may be authorized to retrigger them. I'm not sure.
Next time can you please try it by adding a /rerun-all comment?

@hbelmiro
Copy link
Contributor

hbelmiro commented Aug 1, 2024

/rerun-all

@ElayAharoni
Copy link
Contributor Author

ElayAharoni commented Aug 4, 2024 •
edited
Loading

hi the pr has passed the tests, if i can have another review please.
Please let me know if there is anything else to do before merge.
thanks

@ElayAharoni
Copy link
Contributor Author

hi is there any progress with the review of the pr? please let me know if there is anything i need to do

@ElayAharoni
Copy link
Contributor Author

please if someone can review the PR when possible.
@zijianjoy , @HumairAK

This was referenced Aug 20, 2024
Closed
Merged
@HumairAK HumairAK modified the milestone: KFP 2.4.0 Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HumairAK HumairAK Awaiting requested review from HumairAK

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees
No one assigned
Labels
ok-to-test size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[frontend] Add Create Experiment button when selecting experiement
3 participants
@ElayAharoni @hbelmiro @HumairAK