Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct artifact preview behavior in UI #11059

Merged
merged 1 commit into from
Sep 3, 2024

Commits on Aug 14, 2024

  1. correct artifact preview behavior in UI

    This change allows KFP UI to fallback to UI host namespace when no
    namespaces are provided when referencing the artifact object store
    provider secret, in default kubeflow deployments this namespace is
    simply "kubeflow", however the user can customize this behavior by
    providing the environment variable "SERVER_NAMESPACE" to the KFP UI
    deployment.
    
    Further more, this change addresses a bug that caused URL
    parse to fail when parsing endpoints without a protocol, this will
    support such endpoint types as <ip>:<port> for object store endpoints,
    as is the case in the default kfp deployment manifests.
    
    Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
    HumairAK committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    cb0372f View commit details
    Browse the repository at this point in the history