Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add script and GitHub Action for kfp-kubernetes-library #11006

Merged
merged 3 commits into from
Jul 31, 2024
Merged

test: Add script and GitHub Action for kfp-kubernetes-library #11006

merged 3 commits into from
Jul 31, 2024

Conversation

diegolovison
Copy link
Contributor

@diegolovison diegolovison commented Jul 15, 2024 •
edited
Loading

Description of your changes:
Resolve #11008

Implementation notes:
Removes also the code into oss-test-infra: GoogleCloudPlatform/oss-test-infra#2322

Due that we added sudo in the bash script. The following GHA are failing and are expected

kfp-kubernetes-test-python38	47c82a8	link	true	/test kfp-kubernetes-test-python38
kfp-kubernetes-test-python310	47c82a8	link	true	/test kfp-kubernetes-test-python310
kfp-kubernetes-test-python311	47c82a8	link	true	/test kfp-kubernetes-test-python311
kfp-kubernetes-test-python39	47c82a8	link	true	/test kfp-kubernetes-test-python39
kfp-kubernetes-test-python312	47c82a8	link	true	/test kfp-kubernetes-test-python312

Checklist:

@google-oss-prow Google OSS Prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@diegolovison diegolovison force-pushed the kfp-kube-test-py38 branch 5 times, most recently from f929716 to f24a090 Compare July 15, 2024 20:05
@diegolovison diegolovison changed the title TBD test: Add script and GitHub Action for kfp-kubernetes-test-python38 Jul 15, 2024
@diegolovison diegolovison marked this pull request as ready for review July 15, 2024 20:07
@google-oss-prow google-oss-prow bot requested a review from chensun July 15, 2024 20:07
@diegolovison diegolovison force-pushed the kfp-kube-test-py38 branch 2 times, most recently from 741693a to 9096059 Compare July 15, 2024 20:26
@diegolovison diegolovison marked this pull request as draft July 15, 2024 20:35
@diegolovison diegolovison changed the title test: Add script and GitHub Action for kfp-kubernetes-test-python38 test: Add script and GitHub Action for kfp-kubernetes-library Jul 15, 2024
@diegolovison diegolovison marked this pull request as ready for review July 15, 2024 21:02
@diegolovison diegolovison marked this pull request as draft July 15, 2024 21:07
@google-oss-prow google-oss-prow bot requested a review from zijianjoy July 15, 2024 21:10
hbelmiro
hbelmiro suggested changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @diegolovison. Looks good in general.
I left a few comments.

Also, can you please:

.github/workflows/kfp-kubernetes-test.yaml Outdated Show resolved Hide resolved
.github/workflows/kfp-kubernetes-test.yaml Outdated Show resolved Hide resolved
.github/workflows/kfp-kubernetes-test.yaml Outdated Show resolved Hide resolved
test/presubmit-test-kfp-kubernetes-library.sh Outdated Show resolved Hide resolved
@google-oss-prow Google OSS Prow
Copy link

@diegolovison: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kfp-kubernetes-test-python38 47c82a8 link true /test kfp-kubernetes-test-python38
kfp-kubernetes-test-python310 47c82a8 link true /test kfp-kubernetes-test-python310
kfp-kubernetes-test-python311 47c82a8 link true /test kfp-kubernetes-test-python311
kfp-kubernetes-test-python39 47c82a8 link true /test kfp-kubernetes-test-python39
kfp-kubernetes-test-python312 47c82a8 link true /test kfp-kubernetes-test-python312

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@diegolovison diegolovison mentioned this pull request Jul 16, 2024
Merged
@hbelmiro
Copy link
Contributor

hbelmiro commented Jul 16, 2024 •
edited
Loading

/lgtm

/hold until GoogleCloudPlatform/oss-test-infra#2322 gets merged to avoid failing tests.
cc @DharmitD @chensun @zijianjoy

@google-oss-prow google-oss-prow bot added the lgtm label Jul 16, 2024
DharmitD
DharmitD reviewed Jul 16, 2024
View reviewed changes
Copy link
Contributor

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

chensun
chensun approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hbelmiro
Copy link
Contributor

/unhold as GoogleCloudPlatform/oss-test-infra#2322 got merged.

@hbelmiro
Copy link
Contributor

/hold cancel

@hbelmiro
Copy link
Contributor

@diegolovison tide is preventing the merge because kfp-kubernetes-test-python310 has not succeeded.
Now that GoogleCloudPlatform/oss-test-infra#2322 has been merged, can you rebase so those jobs are removed?

@diegolovison
test: Add script and GitHub Action for kfp-kubernetes-library
068335c 
Signed-off-by: Diego Lovison <diegolovison@gmail.com>
@diegolovison
Rename
c65d911 
Signed-off-by: Diego Lovison <diegolovison@gmail.com>
@diegolovison
Update bash to have sudo
8018f4c 
Signed-off-by: Diego Lovison <diegolovison@gmail.com>
@google-oss-prow google-oss-prow bot removed the lgtm label Jul 31, 2024
@google-oss-prow Google OSS Prow
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-prow google-oss-prow bot merged commit c420f8c into kubeflow:master Jul 31, 2024
2 checks passed
hbelmiro added a commit to hbelmiro/data-science-pipelines that referenced this pull request Aug 5, 2024
@hbelmiro
Revert "test: Add script and GitHub Action for kfp-kubernetes-library (…
64d30b6 
…kubeflow#11006)"

This reverts commit c420f8c.
droctothorpe pushed a commit to droctothorpe/pipelines that referenced this pull request Aug 13, 2024
@diegolovison @droctothorpe
test: Add script and GitHub Action for kfp-kubernetes-library (kubefl…
ec456c6 
…ow#11006)

* test: Add script and GitHub Action for kfp-kubernetes-library

Signed-off-by: Diego Lovison <diegolovison@gmail.com>

* Rename

Signed-off-by: Diego Lovison <diegolovison@gmail.com>

* Update bash to have sudo

Signed-off-by: Diego Lovison <diegolovison@gmail.com>

---------

Signed-off-by: Diego Lovison <diegolovison@gmail.com>
R3hankhan123 pushed a commit to R3hankhan123/pipelines that referenced this pull request Sep 20, 2024
@diegolovison @R3hankhan123
test: Add script and GitHub Action for kfp-kubernetes-library (kubefl…
d2bc6b1 
…ow#11006)

* test: Add script and GitHub Action for kfp-kubernetes-library

Signed-off-by: Diego Lovison <diegolovison@gmail.com>

* Rename

Signed-off-by: Diego Lovison <diegolovison@gmail.com>

* Update bash to have sudo

Signed-off-by: Diego Lovison <diegolovison@gmail.com>

---------

Signed-off-by: Diego Lovison <diegolovison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DharmitD DharmitD DharmitD left review comments

@hbelmiro hbelmiro hbelmiro requested changes

@chensun chensun chensun approved these changes

@gkcalat gkcalat Awaiting requested review from gkcalat

@rimolive rimolive Awaiting requested review from rimolive

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees

@chensun chensun

@hbelmiro hbelmiro

@DharmitD DharmitD

Labels
approved size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] Move kfp-kubernetes-library-tests to GitHub Actions
4 participants
@diegolovison @hbelmiro @chensun @DharmitD