Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: server should skip sample load if path DNE #10833

Merged
merged 1 commit into from
May 24, 2024

Conversation

DharmitD
Copy link
Contributor

@DharmitD DharmitD commented May 19, 2024

Description of your changes:
Resolves #10832

Checklist:

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@google-oss-prow google-oss-prow bot requested review from rimolive and Tomcli May 19, 2024 01:12
Copy link

@DharmitD: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipeline-upgrade-test 8ff7601 link false /test kubeflow-pipeline-upgrade-test
kubeflow-pipeline-e2e-test 8ff7601 link false /test kubeflow-pipeline-e2e-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@DharmitD
Copy link
Contributor Author

@chensun could you please take a look? Thanks.

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 01ee4af into kubeflow:master May 24, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Pipeline server should skip sample load if path DNE
4 participants