Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK/Components - Handling public GCS URIs in load_component_from_url #1057

Merged
merged 1 commit into from
Mar 28, 2019
Merged

SDK/Components - Handling public GCS URIs in load_component_from_url #1057

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions sdk/python/kfp/components/_components.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,12 @@ def load_component_from_url(url):
'''
if url is None:
raise TypeError

#Handling Google Cloud Storage URIs
Ark-kun marked this conversation as resolved.
Show resolved Hide resolved
if url.startswith('gs://'):
#Replacing the gs:// URI with https:// URI (works for public objects)
url = 'https://storage.googleapis.com/' + url[len('gs://'):]

import requests
resp = requests.get(url)
resp.raise_for_status()
Expand Down