Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler unit test bug #1048

Merged
merged 1 commit into from
Mar 27, 2019
Merged

Fix compiler unit test bug #1048

merged 1 commit into from
Mar 27, 2019

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Mar 26, 2019

This change is Reviewable

@gaoning777 gaoning777 changed the title fix bug fix compiler unit test bug Mar 26, 2019
@gaoning777 gaoning777 changed the title fix compiler unit test bug Fix compiler unit test bug Mar 26, 2019
@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 26, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e90a334 into kubeflow:master Mar 27, 2019
@gaoning777 gaoning777 deleted the fix-compiler-unittest-bug branch March 27, 2019 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants