Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing comma-delimited column names #1044

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Mar 26, 2019

This way multiple column names can be passed in a single argument.


This change is Reviewable

Copy link
Contributor

@hongye-sun hongye-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Mar 27, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Mar 28, 2019

/test kubeflow-pipeline-e2e-test

@k8s-ci-robot k8s-ci-robot merged commit 211f53e into kubeflow:master Mar 28, 2019
@Ark-kun Ark-kun deleted the Allow-passing-comma-delimited-column-names branch March 29, 2019 21:43
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
* WIP: Support last_idx and last_elem

* WIP: SDK changes to support last-idx variable.

* fix

* fix sdk param

* fix controller to correctly update results

* fix tests

* fix unit tests and lint

* fix test cases to be executable (#5)

* fix unit tests and lint

* fix test cases to be executatble

* removed unused code and added test

* fix test

Co-authored-by: Tommy Li <Tommy.chaoping.li@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants